Preserved Topic: php/sql - how to insert into a table?

this is a stupid/newbie question, but i just dont get it. i wanna insert some values into a table and im using this code:


$link = mysql_pconnect("db.embege.f2s.com","embege","guess again....hehe");

mysql_select_db("embege",$link) or die("Unable to select database");

mysql_query("INSERT INTO guests (guest_name,guest_email,guest_message) VALUES ($fname, $femail, $fmessage)")
or die("Insert Failed!");


i get "insert failed". whats wrong?

The poster has demanded we remove all his contributions, less he takes legal action.
We have done so.
Now Tyberius Prime expects him to start complaining that we removed his 'free speech' since this message will replace all of his posts, past and future.
Don't follow his example - seek real life help first.

thanks for the quick answer, ini! it works!

now i have just another simple question:
how do i redirect to a page in php?
(javascript would be: document.location="...")

im trying: header("Location: http:.... ");
but, that gives me an error: headers already send

Your code is correct, but if PHP has sent *any* text at that point, it has sent headers already. So that command has to preced any code that outputs. Including HTML outside the <?php ?> delimiters.

Also, ALWAYS check the return code from that query.
Like this:
$result = mysql_query(SQL1, $db);
// obligatory check of result code, verbose error reporting here
if (!$result) {
$errno = mysql_errno($db);
$error = mysql_error($db);
echo "Result = $errno : $error \n";
exit;
}

You get a detailed error message that way.

Also, another good thing is to call exit() after header("Location: blah")...

Hmm, no one mentioned that InI is wrong. Well, half wrong. The single quotes are indeed necessary for the insert. But concatenating the variables is UNNECESSARY. The way you originally had it was only missing the isngle quotes. For those who don't know, you can specify strings with either single or double quotes in PHP. If you use single quotes, the string is NOT PARSED and is literally exactly what you put in it. If you use double quotes then it parses for variables and special characters, such as \n for linefeed, and \t for tab. The one thing you need to watch out for is complex variable references (ie object or variable variable references). In this case you can encase the variable reference within curly braces for it to resolve correctly.

$obj = new Object('10');

$var = 20;

echo('$obj->value & $var\n');

echo("\n$obj->value & $var\n");

echo("{$obj->value} & var\n");

Outputs:

$obj->value & $var\n
ObjectReference#->value & 20
10 & 20

Actually I'm not sure what line 2 would be. At any rate, the poit is it would print whatever it prints when you specify to print an object, but it wouldn't reference the varaible it points to because it doesn't evaluate operators without the curly braces.

-jiblet

Yes but it is SQL code he was refering to, not PHP code

if you wanna redirect a page after the headers are sent you can easily echo the

<script language="javascript">

document.location='';

</script>

bit dependent on an if() statement.

this is the method i use for my click counting script.

{ kat ; mmm.. a site! }

Kat, if some of your visitors have JS turned off that method won't work...