OZONE Asylum
Forums
Site reviews!
okay giv'it to me...
This page's ID:
23370
Search
QuickChanges
Forums
FAQ
Archives
Register
Edit Post
Who can edit a post?
The poster and administrators may edit a post. The poster can only edit it for a short while after the initial post.
Your User Name:
Your Password:
Login Options:
Remember Me On This Computer
Your Text:
Insert Slimies »
Insert UBB Code »
Close
Last Tag
|
All Tags
UBB Help
Overall things appear to be much better. The code is quite a bit cleaner, and the layout feels a little more pulled together. Still some odd things going on in the code though - 1) you have your navigation menu setup as list items, but you have no list! 2) Headers are still a bit out of whack, as far as code structure goes 3) Try to cut out as many of the wrapping <div>'s and <span>'s as possible - apply the styling directly to the element you are styling rather than to a "wrapper". For example - [code] <h2> features Samoana Online </h2> <div ID="item1"> <div ID="i1image" class="b-link"> <img src="efarani.jpg" alt="Elizabeth Tuisalega Farani" border="0"><br> Miss NZ Asia Pacific<br> <span class="smtext">Photo by Trish Newsham</span><p> </div> <div ID="i1story" class="newstext"> <span class="newstexth1">Samoan girls sweep the Miss NZ Asia Pacific Pageant</span><p> It's official: Samoan girls are beauty queens! <p> This past saturday (25/09/04) NZ Samoans took out the competition at the Miss NZ Asia Pacific, with four of our girls placing at the end of the night. <p> Elizabeth Tuisalega Farani (left) won the overall title in a pageant where countries as diverse as the Philipines, Taiwan, Cambodia and Thailand were also represented. She will go on to compete in the Miss Global Tourism Pageant held in Alberta, Canada in November. <p align="right"><span class="b-link"><a href="newspaper.html#ms"> // more photos // </a> </span>[/code] I would code more like this - [code]<h1>features Samoana Online</h1> //this is a top level header, should be an H1. Also, why an &nbsp;?? <div ID="item1"> <div class="photo-left">//just make one generic class for photos such as these <img src="efarani.jpg" alt="Elizabeth Tuisalega Farani" height="" width="">//make sure you add your height and width! Use css to set border:none; <br> Miss NZ Asia Pacific <br> <span class="smtext">Photo by Trish Newsham</span>//rogue <p> tag was here...? </div> <div class="newstext">//no need for the ID here, use a single generic class <h2>Samoan girls sweep the Miss NZ Asia Pacific Pageant</h2>//this is a header! code it as one. it is a 2nd level header... <p> It's official: Samoan girls are beauty queens! </p> <p> This past saturday (25/09/04) NZ Samoans took out the competition at the Miss NZ Asia Pacific, with four of our girls placing at the end of the night. </p> <p> Elizabeth Tuisalega Farani (left) won the overall title in a pageant where countries as diverse as the Philipines, Taiwan, Cambodia and Thailand were also represented. She will go on to compete in the Miss Global Tourism Pageant held in Alberta, Canada in November. </p> <p class="b-link" align="right">//no need for a span! add the class declaration to the <p> <a href="newspaper.html#ms">// more photos //</a>why spaces in your links??? </p> [/code] There are a lot of such instances where you can cut out a lot of the redundant code. Also, the navigation menu still feels very detached from the rest of the page. All in all, this is a good improvement though. [url=http://in-dented.com/sigs.html][img]http://www.in-dented.com/sigs/knot_sig_32.gif[/img][/url] [small](Edited by [internallink=163]DL-44[/internallink] on 09-29-2004 19:38)[/small]
Loading...
Options:
Enable Slimies
Enable Linkwords
« Backwards
—
Onwards »