code walkthrough please? — OZONE Asylum, home of the Mad Scientists

XML - XSL - XSLT - XHTML - CSS - DOM

code walkthrough please?

This page's ID: 26755

Edit Post

Who can edit a post?	The poster and administrators may edit a post. The poster can only edit it for a short while after the initial post.

Your User Name:
Your Password:
Login Options:	Remember Me On This Computer

Your Text: Insert Slimies » Insert UBB Code » Close Last Tag \| All Tags UBB Help	I took a quick look. The HTML is great. I was surprised how short it was considering how complicated the page looks. It also looks very semantically correct. You could make your alt text for the images a little more helpful for people who can't view the images. For instance, "today's highlight!" doesn't fill in the fact that the image I can't see has harry potter on it. Maybe this is just because it's a test page, but it won't hurt to keep in mind. The page degenerates well when CSS is turned off. The CSS is a little confusing, simply because of a lack of formatting. I'd recommend spreading things out a little by putting each property on its own line. This will only introduce a newline and possibly a tab for each CSS property, so it shouldn't bring the filesize up much, but I'd imagine it would be much easier to edit and read. You might also want to comment a little more to clarify what parts of the page the CSS is intended to modify, and how. The code itself looks fine, you're making good use of cascading and not specifying properties in more than one place. Functionally, the CSS is good. The JavaScript is decent. The addClass and removeClass functions worry me slightly because they don't account for class names that are sub parts of other class names. For instance, if an element had class "notred" and you tried to add the class "red" to it with addClass, it wouldn't work because "red" is already a part of that element's classname. This obviously isn't an issue on your page, but you'll have to be careful if you reuse those functions. Otherwise the code is fine. [url=http://www.slimeland.com/] [img]http://www.slimeland.com/misc/ozonemetalslimesig.gif[/img] [/url] Loading...
Options:	Enable Slimies Enable Linkwords

« Backwards — Onwards »

Show Forum Drop Down Menu