Topic: Javascript problem

ok i have this code which opens a centralised new window with the home page then sets the browser to refresh after 5 seconds to the home page

<script language="Javascript">
   	function Redirect() {
	window.location="home.htm";
    }
	function NewWindow() {
	left=(700-screen.width)/2;
	top=(150-screen.height)/2;
	window.open("home.htm", "main", "resizable=1,HEIGHT=423,WIDTH=700,left=150,top=150,screenX=left,screenY=top");
	Refresh=setTimeout("Redirect()",5000);
	}
    function Stopit() {
    clearTimeout(Refresh);
    }
	</script>

then in the body tag on the "home.htm" page

onload="javascript: window.opener.Stopit()"

the idea of this (incase its not obvios) is so that if the window doesnt open for some reason then the browser will go to the homepage anyway
alright so anyway. My problem is, it doesn't work in IE i found it works fine on other browsers i tested it on but not IE for some reason and i have no idea why
first off the popup doesnt come up, and then it doesnt redirect either
any help appreciated

Nothing pops right out except I'd take out the "javascript: " you shouldn't need it on event handlers so it might be screwing something up.



.:[ Never resist a perfect moment ]:.

there is one little mistake in there, about the "left" and "top" but that wasnt the main problem
it seems to be working now thanks

the javascript: is unecessary but doesn't screw the things up. IMHO what's wrong is the scope of the Refresh variable. It's only declared and assigned in the newWindow function, so it is unknown in the stopIt function. Simply add a

var Refresh

outside of all functions so the variable is available and known from every functions, and voilà.

Hope that helps,



(Edited by poi on 05-27-2006 23:52)

ok that helps too thanks
in your opinion is it good?
i think this is acutally probably the first thread i've started where the first response wasn't something like "well why would you want to do that" or "that's a really ineficient way of doing that"

Hard to say if its "good" or not, I think having an alternative incase a popup doesnt work is a great idea. Was that your question or where you asking about code efficiency or something along those lines?

Does "onload="javascript: window.opener.Stopit()" cause an error if its opened inside window instead of a popup? You may need a if(window.opener) in a seperate function.

Does anyone know the general rule for popup blockers? As far as I knew it only blocks popups set on the onload directly or if its run as the code is read.

Opera and Firefox popup blockers* are quite sophisticated I think. They are trying to block any way of causing popups that is not a direct effect of user interaction. IIRC they do stuff like marking events as user triggered versus script triggered etc. as filter methods for determining whether the popup should be allowed or not, and default to not allowing it.


* Don't know about iew's blocker or those you get with antiviri, adware removers, proxies or firewall software.

--
var Liorean = {
abode: "http://codingforums.com/",
profile: "http://codingforums.com/member.php?u=5798"};