Topic: Undefined offset

Hi there,

First i want to tell i am not that expirienced in PHP however i am able to read and to understand whats going on however i having a hard time to edit PHP.

Since a few days our website reporting some errors.

Like this one:

Notice: Undefined offset: 13 in:
Here is the code which i think is causing the error:

if (substr($fields[11],0,strlen($countryicao)) == $countryicao OR substr($fields[13],0,strlen($countryicao)) == $countryicao) {
                        array_push($pilots, $fields);

I hope you can help me to fix this error.

Thanks in advance

Andresg

Edit TP: added code tags

(Edited by Tyberius Prime on 08-30-2010 12:23)

so $fields does not contain 13 entries. You will need to stick a var_dump($fields); into th line before that to see what's actually in there, and it would really help if you had an idea what should be in there...

well the strange thing is that it start working again a few hours ago, the script it self is just anoying, is there not a way to disable the warning message. or if $fieldsB is empty that he don't show an error?

stick an @ before $fieldsB (or before the substr... my PHP is rusty).

To suppress errors from functions, you need to prefix them with @ (as TP mentioned), i.e. @substr(...)

However, the proper way to fix this would be to check how many elements are in that array, before calling substr, something like this:

if ((count($fields) >= 14 && substr($fields[13],0,strlen($countryicao)) == $countryicao) || (count($fields) >= 12 && substr($fields[11],0,strlen($countryicao)) == $countryicao)) { ... }

nah, the proper way would be to figure out why the array suddenly contains fewer elements than before...

I just suggested an easy way out (that's somewhat better than suppressing errors with @)

As far as variable fields count is concerned, a wild guess would be that fields are being populated by different db queries depending on some criteria, in which case it would be much better to fetch data as associative array and access fields by name. However, without seeing the rest of the code, I would still suggest to simply not waste time on this and take the easy way out (you can't fix every bad code)...

and I say, if you want to kludge, use the most prominent one available, which would be the '@'.
Bonus: It doesn't look like it was intentional coding in the first place, but a horrible horrible damage, eh kludge