Topic awaiting preservation: problems with writing variable in windowopen code

this is the code that im using to pop up a new window:

popupWin = window.open(url,name,"width=wid,height=hei,left=50,screenX=50,top=50,screenY=50");

the width and height should be variable too. but it doesnt work with this code, it only works if i type in the values manually like:

popupWin = window.open(url,name,"width=700,height=500,left=50,screenX=50,top=50,screenY=50");

JavaScript doesn't parse strings (like PHP, for example), so you'll have to write your code like this:

popupWin = window.open(url,name,"width="+wid+",height="+"hei"+",left=50,screenX=50,top=50,screenY=50");

Remember that that string isn't javascript code; it's a string, a piece of data. If you want to put values in there that you don't know ahead of time, then you must do it like this:

popupWin = window.open(url,name,"width=" + wid + ",height=" + hei + ",left=50,screenX=50,top=50,screenY=50");

[edit: rrrrrrr!]

[This message has been edited by Slime (edited 08-06-2002).]

ahhh. of course!
stupid me! i should have known that!

thanks guys!

Grumble, you can still do that:

<script language="JavaScript">

<!--

  function jsprintf()

  {

    // v0.0.1, 06/09/01, 01:26:42PM 

    str = arguments[0]; j = 1;

    while ( (idx = str.indexOf("%s")) != -1)

       str = str.substr(0, idx) + arguments[j++] + str.substr(idx+2);

    return str;

  }

//-->

</script>

use this now as:

popupWin = window.open(url,name,jsprintf("width=%s,height=%s,left=50,screenX=50,top=50,screenY=50", wid, hei));

ah, hehe a JS implementation of C's printf.