Topic: Hows it look? (Page 1 of 1)

I'm not a 'pro' webpage designer, although my work likes to think I am, so simply trying to do my best. However, after going though hell with nested tables, I'm trying to move away from table-based designs and start using CSS, and this page is my first real attempt at doing such.
http://67.70.220.89/cibceshops/index.asp

One thing right off the bat, is that the CSS is at the top of each page. it is actually an <!--include file, I tried using the 'proper'

<link rel="nofollow" href="css/global.css" rel="stylesheet" type="text/css" />

However, whenever I did that, the page would initiatly display all garbled untill I hit refresh, then things would line up properly. Using a <!--#include file="css/global.css"--> while a 'hack', fixed it up for me.


Anywho, any comments/suggestions in terms of the code aspect of it? I have no control over the creative, its what CIBC gave me, and the forms produced on the enter page are produced via ASP, and I dont have any control over that code.

Thanks

Kaniz

Don't have time to be thorough at the moment, but a couple quickies -

1) it needs encoding

2) Some of your IMG tags have the closing "/", but some don't. They'll all need them. Same with the <br />'s
3) The iamges also need to have ALT text specified, and need to have the "border" attribute removed.
You can specify the 0 border in the CSS -
img {
border:none;
}

4) the <span class="text"> is redundant and most likely improper use of the tag. You have it envleoping a variety of things that it shouldn't, and doesn't need to.

If you simply specify the attributes for the body and/or p tag that you have for the "text" class, you can get rid of it altoghether.

Also, to help simplify perhaps - you don't need to specify things that have already been specified. If you specify the font-family for the body, the only thing you need to specify for the "small" class is the font-size, since that's the only thing that changes.

Same with the links. You have the color specified, so for the hover, all you need to specify is the text-decoration, since that's the only change.

5) Remember ti use the W3C validator - it will point out a lot of these issues for you and help pinpoint where each particular problem may be.

Thanks,

question though. If I am using <span> tags incorrectly. If I have the sentance

Little boy blue ran to the zoo, and was scared by a fox

and I want to apply formatting to the word zoo and fox, and make it use the style class .zoo, what would be the correct way of doing that?

Where you have the -

<span class="small">or 100,000 Aeroplan Miles!</span>

That is just fine. That is how they were meant to be used.

What you don't want is the <span class="text"></span> that wraps around that and a few other things.

Ahh ok, thanks.

Also, question

I want to center the page. I've tried doing a

<div align=center>
and it pushs's everything over to the far right of the page and scrolls off the side. Whenever I wanted to center a page before, I'd either do that, or put it into a table with a td align=center

any ideas/suggestions?

For the div that contains everythign add this css rule:
{
margin-left: auto;
margin-right: auto;
}