Topic: Site review Pages that link to <a href="https://ozoneasylum.com/backlink?for=10449" title="Pages that link to Topic: Site review" rel="nofollow" >Topic: Site review\

 
Author Thread
MIDI
Paranoid (IV) Inmate

From: Georgia
Insane since: Dec 2002

IP logged posted posted 10-02-2003 04:51 Edit Quote

Would appreciate another review since converting to xhtml.
Hopefully the link is still with the sig..
Thanks guys...

Dick Ulrich
Bipolar (III) Inmate

From: Dublin, TX, USA
Insane since: Sep 2003

IP logged posted posted 10-02-2003 05:55 Edit Quote

Nice looking site ...
If only my speakers were working ... and me too ...

mas
Paranoid (IV) Inmate

From: the space between us
Insane since: Sep 2002

IP logged posted posted 10-02-2003 14:13 Edit Quote

hey nice site. simple, small, fast. and a nice db of midi's also no tables there.....really nice


twItch^
Maniac (V) Mad Scientist

From: the west wing
Insane since: Aug 2000

IP logged posted posted 10-02-2003 20:11 Edit Quote

is that all hard-coded html? I'm sorry.

Looks the same as it did before, so you're green.

-S

Ramasax
Paranoid (IV) Inmate

From: PA, US
Insane since: Feb 2002

IP logged posted posted 10-03-2003 03:28 Edit Quote

Yep, very clean, very simple, does its job. And a nice collection of MIDIs to boot.

Nice site.

Veneficuz
Paranoid (IV) Inmate

From: A graveyard of dreams
Insane since: Mar 2001

IP logged posted posted 10-03-2003 11:03 Edit Quote

The layout looks like I remeber it, so that there's no problems there. The code looks good as well, except that you've used <br /> tags to create the paragraphs on the first page. Change that to <p> tags and you're all set

_________________________
"There are 10 kinds of people; those who know binary, those who don't and those who start counting at zero"
- the Golden Ratio -

MIDI
Paranoid (IV) Inmate

From: Georgia
Insane since: Dec 2002

IP logged posted posted 10-03-2003 12:15 Edit Quote

twItch... I wish...
Now that I'm not working maybe I'll learn to do my own coding... )
Right now I'm using "html kit & style master".

Also got rid of all the br's I could find on the site.

twItch^
Maniac (V) Mad Scientist

From: the west wing
Insane since: Aug 2000

IP logged posted posted 10-04-2003 04:30 Edit Quote

Less than 100 lines of php would put together a nice little system for you.

Seriously. If your server can run PHP and you have MySQL/mSQL/PostgreSQL, you're green. Simple stuff. Email me if you need some pointers.

-S

sonicsnail
Bipolar (III) Inmate

From: Scotland
Insane since: Jun 2001

IP logged posted posted 10-09-2003 23:37 Edit Quote

"You're green" ?

Michael
Maniac (V) Mad Scientist

From: *land
Insane since: Nov 2000

IP logged posted posted 10-10-2003 01:05 Edit Quote

I depise making posts to make little clarification points like this...
But I'm not going to let this post irk me..... because I'm blaming Stephen for me having to.
*smirk*

sonicsnail - It's like saying... "you're good to go".

JKMabry
Maniac (V) Inmate

From: out of a sleepy funk
Insane since: Aug 2000

IP logged posted posted 10-10-2003 02:34 Edit Quote

"you're good to go" ?

Jason

twItch^
Maniac (V) Mad Scientist

From: the west wing
Insane since: Aug 2000

IP logged posted posted 10-10-2003 09:38 Edit Quote

*eats idioms for breakfast*

-S

HZR
Bipolar (III) Inmate

From: Cold Sweden
Insane since: Jul 2002

IP logged posted posted 10-10-2003 16:23 Edit Quote

Looked through your index page only.

You're using a lot of unnecessary markup. You could delete almost all of your class attributes for instance.

First of all, you could remove the div used for the navigation. Secondly, all items in the menu have a class attribute. Instead, you could give the nav an id and then use something like

code:
#nav li a { ... }

To be real pedantic, maybe it should be an unordered list too.

Is

code:
<base rel="nofollow" href="http://bennieshepherd.com/" />

really needed?

code:
<div class="center">


"center" is not a good classname since it's not really separating style from structure (if you understand what I mean). "main" or similar would be better.

Also, personally I think the "Valid XHTML" and Bobby icons are pretty annoying, and I don't really think people care if your site validates or not (At least I don't).



[This message has been edited by HZR (edited 10-10-2003).]

ozphactor
Maniac (V) Inmate

From: California
Insane since: Jul 2003

IP logged posted posted 10-10-2003 21:10 Edit Quote
quote:
<div class="center">


Actually, since he's using a class selector, it makes sense to call it "center," since there's a possiblity that more than one div will be centered. If he were using an ID selector (which I think is what he meant to use), "main" would be a better name, because there can only be one "main" div.

HZR
Bipolar (III) Inmate

From: Cold Sweden
Insane since: Jul 2002

IP logged posted posted 10-11-2003 11:10 Edit Quote

What difference does it make?
(IMO) you should never use classes/id's that reflects the elements style/position, like "yellow", "left" or similar.
What if he decides to redesign the page with that div aligned to the left. That wouldn't make sense.

BTW, midi, you are sending XHTML as text/html.



[This message has been edited by HZR (edited 10-11-2003).]

[This message has been edited by HZR (edited 10-11-2003).]

ozphactor
Maniac (V) Inmate

From: California
Insane since: Jul 2003

IP logged posted posted 10-12-2003 07:09 Edit Quote

Okay then, suppose I have a few divs on a page that I want centered, purely for visual effect. Assuming contextual selectors are out of the question, how would you approach the situation? I would probably add class="center" to each one, but since you object to this usage, tell us what you would do.

quote:
BTW, midi, you are sending XHTML as text/html.


While I am aware of the issues regarding this, I still send all my XHTML pages as text/html. Why? Because sending them as application/xhtml+xml just happens to break horribly in many of today's browsers, including IE6. I don't want my IE6 users to see this.

So what are my options? Going back to HTML 4, which in my opinion, is taking a step backwards, or using XHTML anyways, which is like taking three-fourths of a step forward, even if I can't always adhere to strict standards.

HZR
Bipolar (III) Inmate

From: Cold Sweden
Insane since: Jul 2002

IP logged posted posted 10-12-2003 12:35 Edit Quote
quote:
tell us what you would do


If it's just for purely visual effects, I can agree with you on doing something like <div class="center">. But then you could also use the <center> tag. As I said earlier, what about when you want to redesign that page and have the divs aligned to the right?

About the XHTML as text/html:
XHTML 1.0 may be sent as text/html (though it should not) if the document follows the appendix C guidelines, as you know ozphactor. However, midis site does not and that's why I pointed it out.

I don't see the benefit of using XHTML today though.



[This message has been edited by HZR (edited 10-12-2003).]

Dracusis
Maniac (V) Inmate

From: Brisbane, Australia
Insane since: Apr 2001

IP logged posted posted 10-13-2003 10:05 Edit Quote

Errr, I thought using contextual selectors and a properly structured and well described and "marked up" page meant you can pin point almost any element in your page (depending on how detailed your class and ID values are).

As per HZR's argument about the issues that might pop up when having to redesign the page, if you use element classes and ID's to describe the document structure (to the detail required by thestyle sheets) then you shouldn?t have an issue. You might end up with redundant CSS rules and selectors, but I think that's a better option than using classes like "centre".

Although, IMHO there's little point structuring detailed descriptions of a document in XHTML if it were just a one off page. So if it was a one-off job, and I was pressed for time, I'd also opt for a "centre" or a "float_left" class, but I'd still think it a poor practice.




MIDI
Paranoid (IV) Inmate

From: Georgia
Insane since: Dec 2002

IP logged posted posted 10-15-2003 19:13 Edit Quote

Don't understand a lot of what you guys are saying. "sending XHTML as text/html", "remove class for menu devision".
I did change div class center to content.
Also went back to dtd html 4.01 transitional.

Steve.. when you said I was green I thought you meant I was new to creating web pages..



Post Reply
 
Your User Name:
Your Password:
Login Options:
 
Your Text:
Loading...
Options:


« BackwardsOnwards »

Show Forum Drop Down Menu