Topic awaiting preservation: Issue with PHP and mySQL Counter Increment (Page 1 of 1)

<?php

   

if(isset($_COOKIE['user_ip'])) $set = true;



if(!$set)

{ 

	setcookie("user_ip", $REMOTE_ADDR, time()+360000);

        $link = mysql_connect($db_uri, $user_name, $pass)

                 or die("Could not connect: " . mysql_error());

	mysql_select_db($user_name) or die("Could not select database" . mysql_error());

	mysql_query("UPDATE simplecount SET count=(count + 1) WHERE count_id=1");

	$inker++;

	$whackerror =  "this is an error used to help report bugs.  please ignore it. - $inker";

}

else

{

	 $link = mysql_connect($db_uri, $user_name, $pass)

       or die("Could not connect: " . mysql_error());

	mysql_select_db($user_name) or die("Could not select database" . mysql_error());

}

?>

<?php

//if(isset($_COOKIE['user_ip'])) $set = true; //completly unnessecary. And a potential bug, too



//repeated code should be written only once.

function error($strMessage)

{

    print $strMessage. ': ';

    print mysql_error(). ' - '. mysql_error();

    die();

}



//common code should be common, not repetead in every instance.

$link = mysql_connect($db_uri, $user_name, $pass) or error("Could not connect"); //using the new error function.

mysql_select_db($user_name) or error("Could not select database"); //and again. We already saved something.



//if(!$set) //what happens if the user appends ?set=true to the url.

//we'll use this instead

if (isset($_COOKIES['user_ip'])) 

{ 

     setcookie("user_ip", $REMOTE_ADDR, time()+360000); //I'd add a path and a domain.

     $iCountID = 1; //we'll be using this magic value twice, so we pull it into a variable.

     mysql_query("UPDATE simplecount SET count=(count + 1) WHERE count_id={$iCountID}") or error("update query failed");

     //$inker++; //now, where does $inker come from. What's it's initial value that you're incrementing.

     $strQuery = "SELECT count FROM simplecount WHERE count_id={$iCountID}";

     $hRes = mysql_query($strQuery);

     if ($hRes)

     {

         $arrRow = mysql_fetch_array($hRes);

         if ($arrRow)

         {

             $inker = $arrRow['count'];

         }

         else

         {

             $inker = 0;

         }	     

     }

     else

     {

         error("select query failed: $strQuery");

     }

     

     $whackerror =  "this is an error used to help report bugs.  please ignore it. - $inker"; //printing this might be a good idea.

}

//no else needed, since the case was now empty

?>

if (!isset($_COOKIES['user_ip'])) 

{ 

	setcookie("user_ip", $REMOTE_ADDR, time()+360000); //I'd add a path and a domain.

	$update_count = true;

	$whackerror = "this is an error used to help report bugs. please ignore it. - $inker";

}



$link = mysql_connect($db_uri, $user_name, $pass) or error("Could not connect");

mysql_select_db($user_name) or error("Could not select database");

$iCountID = 1;	

$updatecount ? mysql_query("UPDATE simplecount SET count=(count + 1) WHERE count_id={$iCountID}") or error("update query failed") : $updatecount = false;