Topic: [code] line-height (Page 1 of 1)

.codeBlock pre {
    font-family: monospace;
    font-size: 1.2em;
    margin: 0px;
    line-height: 80%;
    width: 100%;
}

...is that line-height really necessary? It hurts readability imo.

Agreed. This must be some new addition, I didn't notice it until some days ago.

userContent.css is your friend

Yes, of course, but I consider this a bug, so it really should be fixed :-)

could change it to 1.2em to match the font-size - that would still cut down on the vertical space some, but without any overlap

this is still annoying

very strongly agreed here!
I've all but given up actually reading any code within the code tags...

this would be an awfully quick easy fix...is someone available to do something about this?

If I remember correctly this was introduced due to a bug in one browser or the other... back of my head says 'firefox', but hey,
my memory is sketchy these days.

Let me check with kuckus who did quite a bit of the styling and crossbrowser testing.
If he doesn't remember any problems, we'll give it a try, cool?

Mmm, but if he remembers a problem, let us know please. Some of us, like, know things.

hi there...

What I do remember is that, way back when we launched this thing, thosr styles were what was needed to get acceptable results across IE, FF, OP.

Now obviously this has not been the case any longer for a quite a while already, and I never got around to check the code and think of a fix.

I'd say I'll take care of it tomorrow, but I can't really promise I'll be able to... so please don't let me keep you from doing some fiddling and fixing in case I am not quick enough


[edit: Another thing worth fixing would be the Quote button JS (partial quoting, conversion of whitespaces, slimies..). If anyone has some time on their hands, and cares enough, I'd be quite happy to stop being the sole responsible for that as well. ]

(Edited by kuckus on 07-14-2006 00:52)

OK - I made the changes and just committed them to svn, TP will be uploading soon.

The new styles are:

.codeBlock pre {
    font-family: "Courier New", monospace;
    font-size: 1.1em;
    margin: 0px;
    line-height: 1.33em;
    width: 100%;
}

and it's looking good in all the browsers I have available, so hopefully fixes it for everyone.


Good thing you never gave up on it, reisio

(Edited by kuckus on 07-14-2006 18:48)

There you go, the upload is done.



Btw, would anyone be interested in per forum rss feeds?

Yay, much improved - good job.

Edit TP: Aggressive anti spam stance applied.

(Edited by Tyberius Prime on 10-29-2009 18:20)